[PEPr] Comment on HTML::HTML_Libravatar
| From: | Christian Weiske | Date: | Thu, 19 May 2011 08:11:26 +0000 |
| Subject: | [PEPr] Comment on HTML::HTML_Libravatar | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-54287@lists.php.net to get a copy of this message | ||
I think libravatar is great and welcome a pear package for it.
Your code nevetheless needs some ground work:
- Since you are interfacing a web service, use Services_Libravatar as
package name
- Give the class the proper class names (Services_Libravatar), put them in
the correct place
- You don't need "@access" docblock tags anymore since we're on php5
- You could cache DNS results, which make using an libravatar object for
several email addresses faster
- Please have a look at Net_DNS and if you can use it. Maybe it already
includes sorting by priority, so you don't have to use your own
implementation.
--
http://pear.php.net/pepr/pepr-proposal-show.php?id=658