Re: Re: [PEPr] Comment on HTML::HTML_Libravatar

Hi Till Thanks for the feedback. On Sat, May 21, 2011 at 3:36 PM, till <till@php.net> wrote: > On Thu, May 19, 2011 at 1:08 PM, Melissa Draper <melissa@meldraweb.com> > wrote: > >> - Give the class the proper class names (Services_Libravatar), put them > in > >> the correct place > >> > > > > I'm unsure what you're meaning by "put them in the correct place" > > here. > > The convention is that a class name translates to its file name. In this > case: > Services/Libravatar.php > Thanks! I did eventually figure out from Michael's reply further downthread. > > > > > > >> - You don't need "@access" docblock tags anymore since we're on > >> php5 > >> > > > > I wasn't aware, thanks! I must have been looking at the wrong examples. > > > > > >> - You could cache DNS results, which make using an libravatar object for > >> several email addresses faster > >> > > > > It is my understanding that dns_get_record does cache. At least that's > the > > impression I got when researching caching. > > Do you remember where you read that? I don't seem to be able to find > that in the manual. Regardless, nice find. :-) Maybe Net_DNS can > incorporate those. > Sadly I cannot. I believe it was on stack_overflow that several people mentioned it, but I'm only able to find one person now and it appears they're saying the host OS is doing the caching. If that is the case (and I did do some testing after I initially read the assertions of caching this and saw that it did appear to be much faster for subsequent lookups), I'd still be hesitant to add additional caching as that may interfere with host caching. > > Unless you plan to do 5.3+, I'd probably propose a fallback using > Net_DNS down the road. > > Given that 5.2 is now EOL, I personally don't feel that it's necessary for the extra bulk it would add to using this package going forward. Do you know what the process is for me from here since I've had to rename my package? Do I abandon the initial proposal for a new one under the proper name? I realise that I can edit the form, but I have no idea if this would be bad etiquette. Please advise. Thanks, Melissa.