Re: Re: [PEPr] Comment on HTML::HTML_Libravatar

On Thu, May 19, 2011 at 1:08 PM, Melissa Draper <melissa@meldraweb.com> wrote: >> - Give the class the proper class names (Services_Libravatar), put them in >> the correct place >> > > I'm unsure what you're meaning by "put them in the correct place" here. The convention is that a class name translates to its file name. In this case: Services/Libravatar.php > > >> - You don't need "@access" docblock tags anymore since we're on php5 >> > > I wasn't aware, thanks! I must have been looking at the wrong examples. > > >> - You could cache DNS results, which make using an libravatar object for >> several email addresses faster >> > > It is my understanding that dns_get_record does cache. At least that's the > impression I got when researching caching. Do you remember where you read that? I don't seem to be able to find that in the manual. Regardless, nice find. :-) Maybe Net_DNS can incorporate those. Unless you plan to do 5.3+, I'd probably propose a fallback using Net_DNS down the road. Till