Re: [PEPr] Comment on HTML::HTML_Libravatar

Hi, Thanks for the constructive feedback. I have also replied to Christian's mail, but it seems that despite signing up for the list, I'm was not able to send to it. Feel free to send this on if it also fails to get through moderation there. On Fri, May 20, 2011 at 6:53 AM, Michael Gauthier <mike@silverorange.com>wrote: > > Hi. This is a great start. > > 1.) run phpcs on your code to find many small issues with coding standards > I've fixed the stuff I missed in the makepackage.php file. But I'm not sure what is expected from the phpdocumentor generated docs/ dir. Is there a template that works with the current version that is PEAR standards compliant? I tried quite a few and none passed. > 2.) your example code creates a new object and calls a method on the object > but the URL method is documented as @static and uses $this::foo() > internally. I recommend just using non-static method access. > Fixed. > 3.) The organization of the code doesn't match the PEAR standards. You > should have: > > / > -docs/ > -LICENSE > -package.xml > -Services/ > --Libravatar.php Oh, so that's what was meant by 'correct place'. Thanks! I must have missed that while going over the standards. Mind you I'm on a netbook so the screen size might have made it less obvious. Looking forward to continued feedback. -M