[PEPr] Comment on HTML::HTML_Libravatar

From: Date: Thu, 19 May 2011 18:53:46 +0000
Subject: [PEPr] Comment on HTML::HTML_Libravatar
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-54288@lists.php.net to get a copy of this message
Hi. This is a great start. 1.) run phpcs on your code to find many small issues with coding standards 2.) your example code creates a new object and calls a method on the object but the URL method is documented as @static and uses $this::foo() internally. I recommend just using non-static method access. 3.) The organization of the code doesn't match the PEAR standards. You should have: / -docs/ -LICENSE -package.xml -Services/ --Libravatar.php -- http://pear.php.net/pepr/pepr-proposal-show.php?id=658

« previous php.pear.dev (#54288) next »