Re: [PHP4BETA] cvs: /php4 php.h /php4/ext/standard basic_functions.c basic_functions.h php3_string.h string.c /php4/tests testarray

At 10:11 PM 9/20/99 -0500, Andrei Zmievski wrote:

At 08:47 PM 9/20/99 -0400, Rasmus Lerdorf wrote:

I thought about this while driving home (it may or may not surprise you, but I wasn't happy with the zend_ prefix either), and I think that going for an informative prefix is the way to go. In this case, I'd go with uf_*(), standing for User Function. That would give us uf_num_args() and uf_get_arg().

Perhaps just func_num_args()? uf_ is the sound you make when you get kicked in the groin. Uff... All this could have been avoided if you guys (I'm talking to Zeev and Andi) let us know your intentions of moving some functions over to zend_builtin_functions.c so that we could discuss it. Something as imporant as that warrants peer review, I would think. Now string.c is broken up between two files, and we have to start worrying about possibly maintaining two functions directories.

Well we didn't really discuss it between each other either (as Zeev and I). I didn't think it was a big deal. Zeev added the zend_builtin_functions file for the uf_num_args and uf_get_arg functions, and I just did something which has been bothering me for a long time, which was to move the very core language specific functions over to Zend. It really is no big deal. Obviously if someone else uses the Zend engine he'd need to use those functions as part of the core language, and I wouldn't then want to go and cut&paste from the PHP source tree. Andi --- Andi Gutmans <andi@zend.com> http://www.zend.com/