Sidebar and Dynamic News
| From: | Paul Dragoonis | Date: | Thu, 18 Aug 2011 10:56:07 +0000 |
| Subject: | Sidebar and Dynamic News | ||
| Groups: | php.webmaster | ||
| Request: | Send a blank email to php-webmaster+get-11953@lists.php.net to get a copy of this message | ||
Hey Stewart + all,
As discussed previously I'd get back into the new prototype again. Here is
my first patch in a while with more to come.
I have attached my patch here for review before i commit it to SVN.
I've also attached a screenshot for those who want to see visual changes
without importing a patch.
I took our discussion of Dynamic News and went with it.
Firstly, I took the initiative of separating our App logic and our
Presentation logic, (or merely just not putting inline HTML into our main
backend pages).
The initial implementation of the news here was in a HEREDOC and that was
just horrible.
I've added a new function called print_view() this guy is our way to hand
off Presentation logic into its own file giving us a maintainability boost
and all the goodness you get from views in general.
For example on loading the sidebar I've done
print_view('homepage/sidebar.php'); which in turn loads the individual views
for the news, user groups, conferences and the Thanks sections. It's much
more organised now! yay!
I also modified the <h2> CSS styles on the right hand side (visible in the
screenshot). Beforehand we had a border-top on our h2's and it was very
confusing. I've now put the underline/border below the header and it looks
more readable now.
PS: If the code is reviewed and I broke coding standards, let me know it's
been a while!
Regards,
Paul Dragoonis.
Attachment: [image/png] sidebar-old.png
Attachment: [image/png] sidebar-new.png
Attachment: [image/png] sidebar-old.png
Attachment: [image/png] sidebar-new.png