Re: Sidebar and Dynamic News

On Fri, Aug 19, 2011 at 11:20 AM, Hannes Magnusson < hannes.magnusson@gmail.com> wrote: > On Thu, Aug 18, 2011 at 12:56, Paul Dragoonis <dragoonis@gmail.com> wrote: > > Hey Stewart + all, > > As discussed previously I'd get back into the new prototype again. Here > is > > my first patch in a while with more to come. > > I have attached my patch here for review before i commit it to SVN. > > I've also attached a screenshot for those who want to see visual changes > > without importing a patch. > > > - Your editor seems to be messing with trailing whitespace > I'll look at my editor settings > - That print_view() function is useless > It's not useless, we need it to stop horrible code like heredocs everywhere, and we're isolating our app data from the UI so that we're doing PHP inside HTML rather than HTML inside PHP. > - There is dev code in there (error_reporting() and ini_set()) > I had some issues getting up and running initially and they must still be in there, will remove. > - Not all mirrors run PHP5.4, short tags cannot be used > Already removed short tags, haven't sent the following commit. > - The patch seems to be doubled up, all the "views" are twice? > Not sure what you mean, but will re-diff everything. > > We don't really enjoy templating systems of any kind :) > That's good, I don't enjoy any templating systems either. > > The end results looks good though > Thanks. > > -Hannes > Will amend and patch again.