Re: Sidebar and Dynamic News

On 2011-08-18, at 3:56 AM, Paul Dragoonis wrote: > Hey Stewart + all, > > As discussed previously I'd get back into the new prototype again. Here is my first patch > in a while with more to come. Hey Paul, this is great to see! Thanks. > I have attached my patch here for review before i commit it to SVN. > I've also attached a screenshot for those who want to see visual changes without importing > a patch. Hannes would be the best person to review the patch. I am not as familiar with the codebase and have tried to disturb it as little as possible. > I took our discussion of Dynamic News and went with it. > > Firstly, I took the initiative of separating our App logic and our Presentation logic, (or > merely just not putting inline HTML into our main backend pages). > The initial implementation of the news here was in a HEREDOC and that was just horrible. > > I've added a new function called print_view() this guy is our way to hand off Presentation > logic into its own file giving us a maintainability boost and all the goodness you get from views in > general. > > For example on loading the sidebar I've done print_view('homepage/sidebar.php'); > which in turn loads the individual views for the news, user groups, conferences and the Thanks > sections. It's much more organised now! yay! This sounds like a definite improvement. Anything to clean this code up sounds good provided it doesn't destabilize the live site. > I also modified the <h2> CSS styles on the right hand side (visible in the screenshot). > Beforehand we had a border-top on our h2's and it was very confusing. I've now put the > underline/border below the header and it looks more readable now. Sure, looks good. I was thinking of applying some aspects of the doc sidebar to the home page. I haven't tried it yet, but I think it could help tie things together. > PS: If the code is reviewed and I broke coding standards, let me know it's been a while! I'll defer to Hannes again. I'm not familiar with the coding standards (or if there even are any). > Regards, > Paul Dragoonis. Thanks again Paul! I guess next up are the conferences and user group events sections? Stew