Re: Sidebar and Dynamic News
| From: | Hannes Magnusson | Date: | Fri, 19 Aug 2011 10:20:02 +0000 |
| Subject: | Re: Sidebar and Dynamic News | ||
| References: | 1 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-11968@lists.php.net to get a copy of this message | ||
On Thu, Aug 18, 2011 at 12:56, Paul Dragoonis <dragoonis@gmail.com> wrote:
> Hey Stewart + all,
> As discussed previously I'd get back into the new prototype again. Here is
> my first patch in a while with more to come.
> I have attached my patch here for review before i commit it to SVN.
> I've also attached a screenshot for those who want to see visual changes
> without importing a patch.
- Your editor seems to be messing with trailing whitespace
- That print_view() function is useless
- There is dev code in there (error_reporting() and ini_set())
- Not all mirrors run PHP5.4, short tags cannot be used
- The patch seems to be doubled up, all the "views" are twice?
We don't really enjoy templating systems of any kind :)
The end results looks good though
-Hannes