Re: Sidebar and Dynamic News

On Fri, Aug 19, 2011 at 12:39 PM, Paul Dragoonis <dragoonis@gmail.com>wrote: > > > On Fri, Aug 19, 2011 at 12:29 PM, Hannes Magnusson < > hannes.magnusson@gmail.com> wrote: > >> On Fri, Aug 19, 2011 at 13:24, Paul Dragoonis <dragoonis@gmail.com> >> wrote: >> > >> > >> > On Fri, Aug 19, 2011 at 11:20 AM, Hannes Magnusson >> > <hannes.magnusson@gmail.com> wrote: >> >> >> >> On Thu, Aug 18, 2011 at 12:56, Paul Dragoonis <dragoonis@gmail.com> >> wrote: >> >> > Hey Stewart + all, >> >> > As discussed previously I'd get back into the new prototype >> again. Here >> >> > is >> >> > my first patch in a while with more to come. >> >> > I have attached my patch here for review before i commit it to SVN. >> >> > I've also attached a screenshot for those who want to see visual >> changes >> >> > without importing a patch. >> >> >> >> >> >> - Your editor seems to be messing with trailing whitespace >> > >> > I'll look at my editor settings >> > >> >> >> >> - That print_view() function is useless >> > >> > It's not useless, we need it to stop horrible code like heredocs >> everywhere, >> > and we're isolating our app data from the UI so that we're doing PHP >> inside >> > HTML rather than HTML inside PHP. >> >> How does splitting every little area into chunkloads of files help with >> things? >> All that function essentially does is include, with a twist of >> extract().. I really don't see the use. >> > > Splitting our app code up with our "views" code will make code chunks more > maintainable and readable. > Having all the app logic and UI logic mixed in is a very painful codebase > to work with. > > We could merge the four view files into just 'sidebar.php' that is a good > compromise, I feel that the split approach on the sidebar view files was a > bit "too" organised. > > Lets get this wrapped up, move on from debating and start pumping out > features, we can refactor a bit later :-) > > Thanks for your feedback thus far, appreciated. > I'm back, I've fixed my editor to show whitespace and tab/spaces. I converted all my added code to spaces for indentation instead of tabs. I've taken Hannes' feedback into consideration and fixed up the view files so instead of 5 there is only 1, which I do like more now. My patch is attached, if anyone has no problems with it i'm happy to commit and move onto something else. Cheers, Paul. > > Cheers, > Paul. > > >> >> -Hannes >> > >