Re: Sidebar and Dynamic News
| From: | Paul Dragoonis | Date: | Tue, 30 Aug 2011 15:44:26 +0000 |
| Subject: | Re: Sidebar and Dynamic News | ||
| References: | 1 2 3 4 5 6 7 8 9 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-12088@lists.php.net to get a copy of this message | ||
On Tue, Aug 30, 2011 at 4:36 PM, Hannes Magnusson
<hannes.magnusson@gmail.com> wrote:
> On Tue, Aug 30, 2011 at 17:32, Stewart Lord <stewey@ambitious.ca> wrote:
>>
>> On 2011-08-25, at 5:15 AM, Paul Dragoonis wrote:
>>
>> On Thu, Aug 25, 2011 at 1:14 PM, Paul Dragoonis <dragoonis@gmail.com> wrote:
>>>
>>> I'm back, I've fixed my editor to show whitespace and tab/spaces. I
>>> converted all my added code to spaces for indentation instead of tabs.
>>> I've taken Hannes' feedback into consideration and fixed up the view files
>>> so instead of 5 there is only 1, which I do like more now.
>>> My patch is attached, if anyone has no problems with it i'm happy to
>>> commit and move onto something else.
>>
>> Forgot the attachment, duh! - here it is now.
>>
>>>
>>> Cheers,
>>> Paul.
>>
>> Hannes did you get a chance to review this new version?
>
> Well, I completely disagree with the whole print_view() concept. The
> onlything it does is add extra step and confusion when debugging.
> But since its his implementation its eventually his call.
I'm pushing for the separation of app logic and presentation logic
with the most minimal overhead possible.
>
> I thought this was committed already though.
I didn't have time to commit, I had to go disappear for the weekend.
Committed it now.
More stuff coming.
Cheers,
Paul Dragoonis.
>
> -Hannes
>