Re: Package Proposal: DICOM_File
| From: | Xavier Noguer | Date: | Mon, 12 May 2003 21:43:04 +0000 |
| Subject: | Re: Package Proposal: DICOM_File | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-16199@lists.php.net to get a copy of this message | ||
El Lun 12 May 2003 17:06, Bertrand Mansion escribió:
> <xnoguer@rezebra.com> wrote :
> > El Lun 12 May 2003 02:05, Bertrand Mansion escribió:
> >> the code was not CS compliant.
> >
> > This bug has been fixed in my local version.
> >
> > In case this was a PHP problem, snapshots of the sources were uploaded
> > five minutes ago; this change will be in the current snapshot. You can
> > grab the snapshot at
> > http://www.dcc.uchile.cl/~xnoguer/DICOM/.
> >
> > In case this was a documentation problem, the fix will show up soon at
> > http://www.dcc.uchile.cl/~xnoguer/DICOM/apidoc/.
> >
> > Thank you for the report, and for helping us make PHP better.
> >
> >
> > There were a few tabs in the code and a couple of missing @return's. It's
> > been fixed.
>
> Hi,
>
> I have looked at the new version and it looks like every control structures
> are not PEAR CS compliant.
Only the non one-liners actually. I like to use one true brace for control
structures.
> You can have a look at them here:
> http://pear.php.net/manual/en/standards.control.php
Fixed. If you find any other BS (breach in the standards) please let me know
:)
> I wish I had a preformatted message to send you as well but I couldn't find
> one, sorry.
:)