Re: Package Proposal: DICOM_File
| From: | Pierre-Alain Joye | Date: | Mon, 12 May 2003 07:45:22 +0000 |
| Subject: | Re: Package Proposal: DICOM_File | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-16177@lists.php.net to get a copy of this message | ||
Hello,
On Mon, 12 May 2003 08:05:27 +0200
Bertrand Mansion <bmansion@mamasam.com> wrote:
> Time the package proposal was posted: 0:56
> Time you posted your vote: 1:07
>
> That's 11 minutes at max to review more than 2000 lines of code,
> that's very fast IMO. Too fast to notice that the code was not CS
> compliant.
Well, you like to bitch me for every little thing or am I wrong?
I read the sources (and a quick review of the "constants" in
dcom_fields which represent many of the 2000 lines).
Then the source look good as well as the interface. 100% CS should be a
requirement once it's published not for a cvs commit.
I suggest you to stop your timer and keep things about technical issues
in this mailing list, thank's.
pierre