Re: Voting reminder: File_DICOM
| From: | Stefan Walk | Date: | Tue, 20 May 2003 18:19:01 +0000 |
| Subject: | Re: Voting reminder: File_DICOM | ||
| References: | 1 2 3 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-16534@lists.php.net to get a copy of this message | ||
In general, +1 from me also...
but 2 little things:
Maybe you want to put that HUGE array into a global var or static method
(in php5 ;)) so it doesn't get carried around with every instance of the
class, and in "$this->_elements[$group][$element]->_vr_type" you are
accessing a private property of an object from the outside, which
shouldn't be possible ;)
Stefan
--
Stefan Walk
swalk@prp0.prp.physik.tu-darmstadt.de