Re: Voting reminder: File_DICOM
| From: | Xavier Noguer | Date: | Tue, 20 May 2003 21:30:45 +0000 |
| Subject: | Re: Voting reminder: File_DICOM | ||
| References: | 1 2 3 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-16549@lists.php.net to get a copy of this message | ||
El Mar 20 May 2003 14:19, Stefan Walk escribió:
> In general, +1 from me also...
>
> but 2 little things:
>
> Maybe you want to put that HUGE array into a global var or static method
> (in php5 ;)) so it doesn't get carried around with every instance of the
> class,
I don't like the idea of "poluting" the global namespace. I guess I'll have
to wait for php5 :)
> and in "$this->_elements[$group][$element]->_vr_type" you are
> accessing a private property of an object from the outside, which
> shouldn't be possible ;)
Fixed.