Re: Re: [PROPOSAL] DB_Simple
| From: | Paul M Jones | Date: | Sat, 01 Nov 2003 13:43:35 +0000 |
| Subject: | Re: Re: [PROPOSAL] DB_Simple | ||
| References: | 1 2 3 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-23177@lists.php.net to get a copy of this message | ||
On Oct 31, 2003, at 5:06 PM, Marshall Roch wrote:
Davey wrote:Thanks, man. Hope the code meets with similar approval.I think that we should *really* think about offering this up as a sample on how to propose a package.Definitely agreed. Very nice job, Paul.
<snip>I can easily make that a $this->isA() call and not pollute the global namespace; however, I think I need PEAR for the throwError() method. -- pmjAlso, I see no reason for you to be extending PEAR, you only see to use PEAR::isError and as you call that statically, no extension of the PEAR class is needed.If that's the only thing PEAR is used for, you don't need to use PEAR.php at all. Greg suggested the following for File_IMC: if (is_a($err, 'PEAR_Error')) { . . }