Re: [PEPr] Comment on Networking::GeoIP

David Costa wrote:

Hello Mike, thanks for your help ;) quick follow up: so e.g. if (!@$scanned) {

            return PEAR::raiseError(self::MP3_PLAYLIST_OPENDIR_FAILED,
                                    -1, PEAR_ERROR_PRINT);
        }

can be re-written as if (!@!@$scanned) {

            throw new Exception(self::MP3_PLAYLIST_OPENDIR_FAILED);

        }

right ?

Yup, that's right. Also, you don't need to explicitly check whether method calls return exceptions since they will naturally bubble-up. I sent you a w/ Exceptions version of MP3/Playlist.php and for fun MP3/Id.php too -- since that has PEAR dep. HTH, Hans