[PEPr] Comment on Web Services::Services_Memotoo
| From: | Michael Gauthier | Date: | Mon, 21 Apr 2008 03:02:40 +0000 |
| Subject: | [PEPr] Comment on Web Services::Services_Memotoo | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-49834@lists.php.net to get a copy of this message | ||
Michael Gauthier (http://pear.php.net/user/gauthierm) has commented on the proposal for Web
Services::Services_Memotoo.
Comment:
Code looks good in general. You should run the code through phpcs
(http://pear.php.net/package/PHP_CodeSniffer) and fix any errors it finds.
It will prevent nitpicky coding standards issues from holding your package
back from acceptance in PEAR.
Instead of catching exceptions and echoing a message you should throw a
meaningful exception.
Some method documentation is a little sparse. For example, the
documentation for the method addBookmarkFolder is: Add bookMarkfolder. This
may make sense to you but doesn't mean anything to someone else trying to
use the method.
@access tags should not be used for PHP5 code where method/member variable
scope is specified in the declaration.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=554
--
Sent by PEPr, the automatic proposal system at http://pear.php.net