[PEPr] Comment on Web Services::Services_Memotoo
| From: | Till Klampaeckel | Date: | Mon, 21 Apr 2008 17:25:14 +0000 |
| Subject: | [PEPr] Comment on Web Services::Services_Memotoo | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-49846@lists.php.net to get a copy of this message | ||
Till Klampaeckel (http://pear.php.net/user/till) has commented on the proposal for Web
Services::Services_Memotoo.
Comment:
Here are some suggestions:
* You probably don't want to start with 1.0.0 (and stable)
* You could simplify your if/else statements (when they "return").
* You shouldn't use the PHP license as it is incompatible with the GPL
(see LGPL or BSD instead).
* Are all examples listed in package.xml really tests?
* You need to include the package.xml in your tarball (use "pear package"
to create it).
* As suggested, please use exceptions (Services_Memotoo_Exception extend
PEAR_Exception).
* Use phpcs to address CS issues.
* It doesn't hurt to include the <changelog> in your revisions. ;-)
* This is a suggestion, so if you need to include a debugger, maybe think
about accepting a logger instance into your class (optional) or create one
from scratch if none is supplied - this is more helpful in production - at
least instead of "echo'ing" data.
Questions:
1) Does Memotoo adhere to any standard API-wise? Like is it compatible
with other addressbook services (for example, such as Zyb, Plaxo, Google,
...)?
2) On a related note, does Memotoo have a syncml api? I saw that it lists
all kinds of devices on the website, but I couldn't figure out how they
sync.
Thanks!
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=554
--
Sent by PEPr, the automatic proposal system at http://pear.php.net