Re: Re: [PEPr] Comment on Web Services::Services_Memotoo

Philippe Jausions wrote:

Pequet Thomas wrote:

Pequet Thomas (http://pear.php.net/user/memotoo) has commented on the proposal for Web Services::Services_Memotoo. Comment: Thanks for your comments :-) Ok I have modify as you say: - add better documentation for the method - correct error with phpcs (I have just a warning with php version ?)

Things like missing {} blocks for if's, missing spaces around =, <, etc... need to be corrected. Odd, phpcs might be crashing, I'm not getting the error list either. It isn't crashing, there is just no check for control structures without braces.

The PEAR standard does say: "You are strongly encouraged to always use curly braces even in situations where they are technically optional. Having them increases readability and decreases the likelihood of logic errors being introduced when new lines are added." I didn't include that specific check at the time I converted over the PEAR standard, but I think phpcs should probably throw a warning about it (not an error) because it is worded in the same way as the line length standard and phpcs already throws a warning about long lines. Greg