Re: [PEPr] Comment on Web Services::Services_Memotoo

Ok I have understood now ;-) If I have add a class "Services_Memotoo_Exception" extends PEAR_Exception, delete all info "_lastError" and log error file in my class Services_Memotoo. Also I have updated the examples files. For the {} missing blocks, I have add them. You can find the new code here: -> http://www.memotoo.com/softs/?dossier=PEAR_Services_Memotoo&action=telechargerfic&fic=Services_Memotoo-lasted.tgz And the source file: -> http://www.memotoo.com/softs/?dossier=PEAR_Services_Memotoo&action=afficherfic&fic=Memotoo.php Thomas Philippe Jausions a écrit :

Pequet Thomas wrote:

Pequet Thomas (http://pear.php.net/user/memotoo) has commented on the proposal for Web Services::Services_Memotoo. Comment: Thanks for your comments :-) Ok I have modify as you say: - add better documentation for the method - correct error with phpcs (I have just a warning with php version ?)

Things like missing {} blocks for if's, missing spaces around =, <, etc... need to be corrected. Odd, phpcs might be crashing, I'm not getting the error list either.

- write the error in a file if you want, or display these in the browser

Let's keep it simple: Please use exception only, no exit, die, echo. Only return boolean false/true when something is actually tested (e.g. isActive()) not as a flag to determine if the action performed ok. I'm guessing Till was referring to using the PEAR Log package, no need to reinvent the wheel here. Repackage the SOAP exception into your own class exception, don't only keep code and message. Exception have much more information that may be helpful in debugging. -Philippe