[PEPr] +1 for Web Services::Services_Memotoo
| From: | Philippe Jausions | Date: | Mon, 12 May 2008 15:22:41 +0000 |
| Subject: | [PEPr] +1 for Web Services::Services_Memotoo | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-50099@lists.php.net to get a copy of this message | ||
Philippe Jausions (http://pear.php.net/user/jausions) has voted +1 on the proposal for Web
Services::Services_Memotoo.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=554
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=554&handle=jausions
Comment:
In package.xml you marked all the examples as type="test", I guess it
works, still a bit weird though.
Make sure to run PHP_CodeSniffer on your code, I'm pretty sure it'll at
least complain about the missing "PHP version 5" in the file's docBlock.
You don't really need to have @access docTag once you declare the methods
with their scope.
I'd like to see a bit of "breathing" spaces in the for() lines, i.e. put
spaces after ; and around "<", and so on... When everything is jammed
together it makes it a little bit harder to read.
--
Sent by PEPr, the automatic proposal system at http://pear.php.net