[PEPr] Comment on Web Services::Services_Memotoo
| From: | Ken Guest | Date: | Mon, 21 Apr 2008 22:15:10 +0000 |
| Subject: | [PEPr] Comment on Web Services::Services_Memotoo | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-49852@lists.php.net to get a copy of this message | ||
Ken Guest (http://pear.php.net/user/kguest) has commented on the proposal for Web
Services::Services_Memotoo.
Comment:
There are a staggering amount of phpcs highlighted issues in Memotoo.php,
close to 3000 in fact that I'm not sure I want to look at the code - to be
fair it's just a case of working to the PEAR Coding Standards and is not a
major issue at this stage.
It's good to see such a large number of examples too though.
I'd be inclined to rethrow exceptions (and perhaps others) rather than
display the error messages in the constructor, and in other methods of your
API. By doing this you'll give developers using your API the choice to
decide how to handle (and trap) those scenarios better.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=554
--
Sent by PEPr, the automatic proposal system at http://pear.php.net