[PEPr] +1 for Web Services::Services_Memotoo
| From: | Till Klampaeckel | Date: | Fri, 09 May 2008 16:57:51 +0000 |
| Subject: | [PEPr] +1 for Web Services::Services_Memotoo | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-50045@lists.php.net to get a copy of this message | ||
Till Klampaeckel (http://pear.php.net/user/till) has voted +1 on the proposal for Web
Services::Services_Memotoo.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=554
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=554&handle=till
Comment:
Looks pretty clean. Very cool!
Though I have two things:
1) your file layout is off, you want:
Services/Memotoo.php
Services/Memotoo/Exception.php
2) (RE: visibility) I'd go with protected instead of private, private is
only accessible from the class that defines them, if I extend your class I
wouldn't be able to use them.
--
Sent by PEPr, the automatic proposal system at http://pear.php.net