[PEPr] Comment on File System::File_Launcher
| From: | Michael Gauthier | Date: | Wed, 18 Aug 2010 01:32:24 +0000 |
| Subject: | [PEPr] Comment on File System::File_Launcher | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-53678@lists.php.net to get a copy of this message | ||
Great start, thanks for providing unit tests and documentation. Here's my
feedback so far:
1.) run phpcs on the code. It will pick up many formatting errors.
2.) I'm not a big fan of hungarian notation. I don't know of any other PEAR
packages that use it and IMO it doesn't make a lot of sense for a
dynamically typed language.
3.) Use exceptions instead of triggering errors. PEAR packages are not
allowed to use trigger_error.
4.) Package might fit better in the "System" category than the "File"
category. The File category is for file formats. I'd suggest renaming the
package as System_Launcher.
--
http://pear.php.net/pepr/pepr-proposal-show.php?id=642