Re: [PEPr] Proposal for File System::File_Launcher

Hi all, > Olle Jonsson (http://pear.php.net/user/olleolleolle) proposes File > System::File_Launcher. > http://pear.php.net/pepr/pepr-proposal-show.php?id=642 > 2.) I'm not a big fan of hungarian notation. I don't know of any other > PEAR packages that use it and IMO it doesn't make a lot of sense for a > dynamically typed language. I am the one responsible for that code, and I like that notation. And it makes more sense in a dynamically typed language than in a static one: In statically typed languages, you always know the type. IDEs assist you in that. In dynamically typed languages like PHP, this is much much harder to determine. So using prefixes for variables you know the types of is pretty helpful. > I'd consider splitting it into driver type classes if you see more in > depth functionality being required. This also would allow people to > easily mock out the launch command. While this is helpful for big packages, I do not see much value here. Look at the current code [1] - that's half a dozen requires, and as much instances for some drivers. I'd call that overengineered. [1] http://github.com/olleolleolle/File_Launcher/blob/master/System/Launcher.php -- Regards/Mit freundlichen Grüßen Christian Weiske -=≡ Geeking around in the name of science since 1982 ≡=-

Attachment: [application/pgp-signature] signature.asc