Re: [PEPr] Proposal for File System::File_Launcher
| From: | Daniel O'Connor | Date: | Sat, 21 Aug 2010 00:55:32 +0000 |
| Subject: | Re: [PEPr] Proposal for File System::File_Launcher | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-53704@lists.php.net to get a copy of this message | ||
> > I'd consider splitting it into driver type classes if you see more in
> > depth functionality being required. This also would allow people to
> > easily mock out the launch command.
> While this is helpful for big packages, I do not see much value here.
> Look at the current code [1] - that's half a dozen requires, and as
> much instances for some drivers. I'd call that overengineered.
>
>
> Yeah yeah I know - next time I'll add bold around "if you see".