Re: [PEPr] Proposal for File System::File_Launcher
| From: | Matthew Fonda | Date: | Thu, 19 Aug 2010 19:55:38 +0000 |
| Subject: | Re: [PEPr] Proposal for File System::File_Launcher | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-53698@lists.php.net to get a copy of this message | ||
On Thu, Aug 19, 2010 at 12:20 PM, Christian Weiske <cweiske@cweiske.de> wrote:
>> I'd consider splitting it into driver type classes if you see more in
>> depth functionality being required. This also would allow people to
>> easily mock out the launch command.
> While this is helpful for big packages, I do not see much value here.
> Look at the current code [1] - that's half a dozen requires, and as
> much instances for some drivers. I'd call that overengineered.
+1
Best Regards,
--Matthew