[PEPr] +1 for System::System_Launcher
| From: | Bill Shupp | Date: | Thu, 14 Jul 2011 18:22:47 +0000 |
| Subject: | [PEPr] +1 for System::System_Launcher | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-54386@lists.php.net to get a copy of this message | ||
Bill Shupp (http://pear.php.net/user/shupp) has voted +1 on the proposal for
System::System_Launcher.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=642
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=642&handle=shupp
Comment:
Nice work. Two minor comments:
I don't think it's necessary to extend PEAR_Exception (unless there's a
specific reason I'm not aware of), rather just extend Exception.
I've found that is_null() is considerably slower than !== null. You might
consider using that instead.