Re: Re: [PEPr] Comment on File System::File_Launcher
| From: | Daniel O'Connor | Date: | Thu, 19 Aug 2010 02:56:32 +0000 |
| Subject: | Re: Re: [PEPr] Comment on File System::File_Launcher | ||
| References: | 1 2 3 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-53687@lists.php.net to get a copy of this message | ||
On Thu, Aug 19, 2010 at 8:15 AM, Olle Jonsson <olle.jonsson@gmail.com>wrote:
> My initial use-case is the pear report-bug command. The user enters a
> package name, and is sent to a web page where to report her bug, with some
> form values pre-filled. Say, her PHP version, at least.
>
> Cweiske handed me old code to herd, improve, and maintain.
>
> When I return to civilization, I intend to make all the suggested changes.
> All, including name change, make sense to me. I had most of them as TODO
> comments, which I stupidly censored in the checked-in code.
>
> A question on phpcs: the default mode is PEAR, right. Should I run it with
> special parameters to get more serious style complaints? I believed I had
> run it to full compliance. Anyway, I intend to shine up that code.
>
> Could just be package versions - the CI server uses one, the beta release
is different, etc.