Re: [PEPr] Comment on System::System_Launcher

Hi, Le 19/08/2010 19:36, Jesús Espino a écrit :

Nice package, only two comments. Test coverage is near the 50%, not bad, but not good.

Oh come on ;) that's pretty good at proposal time, I mean it's not like there's much activity right now, let's not discourage contributors, PEPR does not requires 100% coverage AFAIK.

And the which command not have -s parameter in all systems, for example, my system (Ubuntu 10.4) don't have the -s parameter in which.

Good point. Another little remark: What about bsd users ? the test on PHP_OS in the portland driver should include 'BSD' and 'Darwin' (see: http://github.com/kvz/system_daemon/blob/master/System/Daemon/OS/BSD.php for an example). Regards, -- David