Re: Plan regarding RC4

I would have been a bit happier seeing this patch going into 4.3.3/4.4.0 or whatever we would want to call it and getting 4.3.2 out the door sooner. But, from what I have seen running it on some large complex applications under serious load along with both Sascha and Wez who know this particular part of the code better than most vouching for it, I am not overly worried about it. There may very well be further bugs, but I think we can be pretty sure that they aren't going to be massive showstoppers that break each and every PHP install out there given the nature of the testing that has gone on so far. The bugs that remain are likely to be edge cases that will not affect huge numbers of people. I think we also have to face the reality that 4.3.0/4.3.1 was not a great release. There are a lot of people out there running 4.2.3 that are waiting for a solid 4.3 before they switch. That means a lot people are likely going to be doing .0-like testing of this stuff before they switch from their 4.2 to 4.3. -Rasmus On Tue, 20 May 2003, Sascha Schumann wrote: > On Tue, 20 May 2003, Zeev Suraski wrote: > > > At 19:24 20/05/2003, Sascha Schumann wrote: > > > The changes are not as massive as Zeev wants you to believe. > > > > How come you introduced 3 crash bugs with this extremely stable patch then? > > Your way of counting is misleading. The changes uncovered > bugs in existing code (lack of proper initialization). All > these have been fixed. > > The require_once/include_once problem was indeed caused by > "late" changes. I initially missed this piece of code > altogether, so that it was not as properly tested as the rest > of the affected infrastructure. This has been rectified as > of today, and thus I cannot share your risk assessment. > > - Sascha > >