Re: Plan regarding RC4

I'll throw my voice in at -0 for this patch at this point in the cycle. While I don't think it's as ugly or foreboding as Zeev makes it to be, I also realize my complete understanding of it's changes is limited. I also tend to dislike the fact that it has been introduced so late in the release cycle as a principle for any new functionality. Though it could be argued (incorrectly) this patch is a bug fix. It comes down to the fact that the Release Master (or whatever title you bestow upon them this week) allowed the changes. I hope that Jani fully understood what was happening with the changes. Many of these concerns should have been brought forth before Sascha applied the changes. Until the RM decides against it, there really doesn't seem to be any point to continuing this discussion. I realize that none of this is based on any technical reasoning, but rather a baseline principle with which to follow for all development. Hence the -0. On Tuesday, May 20, 2003, at 01:44 PM, Sascha Schumann wrote:

On Tue, 20 May 2003, Zeev Suraski wrote:

At 19:24 20/05/2003, Sascha Schumann wrote:

    The changes are not as massive as Zeev wants you to believe.

How come you introduced 3 crash bugs with this extremely stable patch then?

    Your way of counting is misleading.  The changes uncovered
    bugs in existing code (lack of proper initialization).  All
    these have been fixed.

    The require_once/include_once problem was indeed caused by
    "late" changes.  I initially missed this piece of code
    altogether, so that it was not as properly tested as the rest
    of the affected infrastructure.  This has been rectified as
    of today, and thus I cannot share your risk assessment.

    - Sascha

-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php ---------------------------------------------------------------<

Dan Kalowsky                    "Thought I'd visit the club,

http://www.deadmime.org/~dank    Got as far as the door."
dank-nom@aps-deadmime.org      - "Don't Get Around Much Anymore",
kalowsky@php.net                        Ella Fitzgerald