RE: [PHP-DEV] Re: Hold off 5.4
| From: | Andi Gutmans | Date: | Thu, 25 Nov 2010 18:52:51 +0000 |
| Subject: | RE: [PHP-DEV] Re: Hold off 5.4 | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-50567@lists.php.net to get a copy of this message | ||
> -----Original Message-----
> From: Rasmus Lerdorf [mailto:rasmus@lerdorf.com]
> Sent: Thursday, November 25, 2010 10:46 AM
> To: Andi Gutmans
> Cc: Ilia Alshanetsky; Johannes Schlüter; davey@php.net; PHP Internals
> Subject: Re: [PHP-DEV] Re: Hold off 5.4
>
> > Yes I agree. We may be able to skip this check for interned strings which
> would be nice and potentially eliminate performance impact somewhat but it's
> something that would need to be looked into. It's non-trivial but doable (need to
> add a flag for interned strings whether they have a zero byte or not).
>
> I'm not too worried about the performance impact here. Functions that need
> these non-null strings need them because they are about to access the file
> system in some way. The time it takes to check for nulls compared to the file
> system access time is so small that I think we can safely ignore performance
> issues.
Yes I thought about that too after I sent the email :) It is negligible compared to the expensive
filesystem operation.
Andi