Re: Re: Hold off 5.4
| From: | Rasmus Lerdorf | Date: | Thu, 25 Nov 2010 19:05:30 +0000 |
| Subject: | Re: Re: Hold off 5.4 | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-50569@lists.php.net to get a copy of this message | ||
On 11/25/10 11:01 AM, Pierre Joye wrote:
> I noticed it where functions accepts a path, do some checks (exists,
> writable, etc.), resolves paths, etc. and then similar ops are done
> again in a couple of places before we call the low level functions,
> like in stream, tsrm for example, or extension using other extension's
> streams.
>
> The idea is that file.absolute_path, file.original_path, or
> file.resolved_path (example member names) will be passed to the low
> level APIs, where each of them have been checked for NULL as well.
Do you have an example? Also, these checks are going to hit the stat
cache, so I don't think there is much to gain here.
-R