Re: File_CSV as standalone package?
| From: | Stefan Neufeind | Date: | Sat, 30 Aug 2003 07:59:37 +0000 |
| Subject: | Re: File_CSV as standalone package? | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-20849@lists.php.net to get a copy of this message | ||
Hi Marshall,
hehe - while first reading your mail got a bit confused about CSV and
CVS :-)))
On 30 Aug 2003 at 1:46, Marshall Roch wrote:
> Currently, the File package contains support for CSV parsing. I'd
> like to see this moved to its own package, because it really doesn't
> look like it belongs there:
>
> 1) File_CSV doesn't sound like it fits with File's description: "File
> provides an easy interface to PHP's builtin file and directory
> functions, plus some functions to deal with paths."
Agreed.
> 2) File is in the File System category, while File_CSV should be in
> File Formats.
Agreed also from my view. I guess it's historical that it's contained
in "File", right Tomas?
> 3) The only way you'd know it's there is if you happened to stumble
> across it in CVS or caught the very short mention of it in the package
> description.
Agreed also. I didn't yet realise there was a CSV-parsing-engine :-)
> It looks like File_CSV as a separate class would need to depend on
> File, so this would be more of an organizational change than a code
> improvement/fix.
I don't think it will need much improvement over the next years
because I bellieve that CSV won't be improved :-)) But you're right
that inside File it's wrong because File says it belongs to the "File
systems" and also that CSV might be useful as a separate package to
get people to notice it etc.
But since File is marked as "stable" I guess we can't remove CSV from
File. The only solution to me seems a dependency from File to
File_CSV?
By the way: In CSV.php there is the function _dbgBuff() which is
marked "for internal use" and "will be removed in the future". If
you're moving File_CSV maybe this could also be done in one step.
Stefan