Re: Re: HTML_Table: thead, tfoot and tbody
| From: | Bertrand Mansion | Date: | Sat, 30 Jul 2005 07:25:15 +0000 |
| Subject: | Re: Re: HTML_Table: thead, tfoot and tbody | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-39046@lists.php.net to get a copy of this message | ||
Helgi Þormar wrote:
>On Fri, 2005-07-29 at 21:35 +0200, Christian Weiske wrote:
>
>Okey now I get what Christian was talking about :-)
>
>> > - add a fourth parameter to setCellContents():
>> > function setCellContents(int $row, int $col, mixed $contents [[,
>> > string $type='TD'], boolean $tbody = true]);
>> > ==> "normal" data belongs to <tbody>, new parameter allow to add
>> > data
>> > to <tfoot>
>> I wouldn't use a boolean value but a string for parameter types "tbody",
>> "thead" and "tfoot", with "tbody" as default.
>>
>> > - content added by setHeaderContents() belongs to <thead>
>> Because we'd need another function for setFooterContents().
>>
>>
>> What about following:
>> A constructor parameter to determine if the old, non-tbody style should
>> be used or the new one?
>> If we had that, there the class could determine if it has to set the
>> data in the tbody array when they are added with setHeaderContents() or
>> in the thead array. Furthermore, we wouldn't need any extension to
>> setCellContents.
>> I'd also like to have two other convenience methods beside
>> setHeaderCellContents: setBodyCellContents and setFooterCellContents.
>>
>> Oh yeah, not to forget the convenience methods to set a whole row:
>> setHeaderRowContents, setBodyRowContents and setFooterRowContents.
>>
>> That's all :)
>
>Sounds like shitload of extra functions :/
>I'll have to sleep on this before I give any comment (and also review
>the source so I know what I'm saying, way to long since I touched it :))
>
>But all in all it sounds like a nice plan we just have to get an
>agreement, any other people here beside Mark or Christian that have any
>input on this ? Klaus, Bertrand M. ?
That's fine with me, but you will have to update the documentation too.
Bertrand Mansion
Mamasam