Re: [PEPr] +1 for File Formats::File_XSPF

Hi Hannes, The CS issues should be fixed, but if you can provide further specific instances I'd be keen to fix them too. I wrote the package in PHP4 because that is what I still write the majority of my code in, and is currently still more in use than PHP5. That said, I think writing a version of the package in strict PHP5 would bring the benefits you describe, and if there was the facility to have the PHP5 code co-exist, I would release one. As for the concatenation, I can pass off the XML generation to something like XML_FastCreate. Would that satisfy your conditions? Cheers, David Hannes Magnusson wrote: > Hannes Magnusson (http://pear.php.net/user/bjori) has voted +1 on the proposal for File > Formats::File_XSPF. > > Proposal information: > http://pear.php.net/pepr/pepr-proposal-show.php?id=328 > Vote information: > > http://pear.php.net/pepr/pepr-vote-show.php?id=328&handle=bjori > > This vote is conditional. The condition is: > > First off; I can't help wonder if PHP4 based package for this is the way to go. Seems > aaaaalot simpler, and more efficient, implimenting this in PHP5. > > My condition is: For an XML package you use awul lot of string concatenating. Need to solve > that - and those CS issues > -- David Grant http://www.grant.org.uk/