Re: [PEPr] +1 for File Formats::File_XSPF

Hi guys, I'm the lead developper of XML_FastCreate (XFC). I'm not sure to understand why you need to used XFC for your File_XSPF You said to have a lots of XML concatenations, so I suggest you to uses XML_Tree or the native XML functions of PHP5. XFC is a really good tool for end-developpers, it's really usefull to help the developpement "while" your coding (XML valid & respect the DTD), but in your case, I'm not sure this will be a very good choice. Your code will be more clean, but you will lost in performance. Best Regards, Le jeudi 08 décembre 2005 à 13:50 +0000, David Grant a écrit : > Hi Hannes, > > Thanks for all your feedback. All things going well, these changes > should be done by Friday afternoon. > > Cheers, > > David Grant > > Hannes Magnusson wrote: > > [snip] > >>> In XSPF.php you've return (''), return ($this->_annotation), > >>> return > >>> ($this->_attributions)...... > >> Damn it, I was sure that was part of the standards. Guess I must be > >> getting mixed up with other standards! Again, I can't see this being a > >> problem. > > Not a big one, no, but CS is CS ;) > > > > [snip] > >>> Good to hear. Not sure how the best way to have PHP4 and PHP5 versions > >>> of the same package coexists... > >> Greg Beaver was proposing something about adding tags to packages, so > >> perhaps when that concept is introduced I can release both side-by-side. > > Looking forward to it :) > > > >>>> As for the concatenation, I can pass off the XML generation to something > >>>> like XML_FastCreate. Would that satisfy your conditions? > >>> I guess, but Id rather want you to use DOM-XML (don't remember if > >>> there exists any better solution for PHP4). > >> I'd rather not use a PHP extension to do such things because it might > >> not be available, and having that sort of dependency is a pain for users > >> lacking root or administrator access to their server. I guess I could > >> use 'extension_loaded' and fall back to XML_FastCreate, or the string > >> concatenating. Comments? > > > > I was sure the DOMXML extension was loaded by default, which > > apparently its not. Just go ahead and use XML_FastCreate then, > > pointless to create two completly diffrent codes doing the exact same > > thing with no real gain. > > > > - Hannes > > > -- > David Grant > http://www.grant.org.uk/ >