Re: [PEPr] +1 for File Formats::File_XSPF

On 12/8/05, David Grant <david@grant.org.uk> wrote: > Hi Hannes, > > The CS issues should be fixed, but if you can provide further specific > instances I'd be keen to fix them too. http://pear.php.net/manual/en/standards.funcdef.php and http://pear.php.net/manual/en/standards.including.php "Note: include_once and require_once are statements, not functions. Parentheses should not surround the subject filename." return is a language construct, not a function, so the same rules should apply. http://php.net/return "...the parentheses surrounding its arguments are only required if the argument contains an expression" In XSPF.php you've return (''), return ($this->_annotation), return ($this->_attributions)...... > > I wrote the package in PHP4 because that is what I still write the > majority of my code in, and is currently still more in use than PHP5. > That said, I think writing a version of the package in strict PHP5 would > bring the benefits you describe, and if there was the facility to have > the PHP5 code co-exist, I would release one. Good to hear. Not sure how the best way to have PHP4 and PHP5 versions of the same package coexists... > > As for the concatenation, I can pass off the XML generation to something > like XML_FastCreate. Would that satisfy your conditions? I guess, but Id rather want you to use DOM-XML (don't remember if there exists any better solution for PHP4). > > Cheers, > > David > > Hannes Magnusson wrote: > > Hannes Magnusson (http://pear.php.net/user/bjori) has voted +1 on the proposal for File > > Formats::File_XSPF. > > > > Proposal information: > > http://pear.php.net/pepr/pepr-proposal-show.php?id=328 > > Vote information: > > > > http://pear.php.net/pepr/pepr-vote-show.php?id=328&handle=bjori > > > > This vote is conditional. The condition is: > > > > First off; I can't help wonder if PHP4 based package for this is the way to go. Seems > > aaaaalot simpler, and more efficient, implimenting this in PHP5. > > > > My condition is: For an XML package you use awul lot of string concatenating. Need to > > solve that - and those CS issues > > > > > -- > David Grant > http://www.grant.org.uk/ >