[PEPr] +1 for System::System_Folders

From: Date: Sat, 04 Mar 2006 22:35:57 +0000
Subject: [PEPr] +1 for System::System_Folders
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-41658@lists.php.net to get a copy of this message
Michal Felski (http://pear.php.net/user/fela) has voted +1 on the proposal for System::System_Folders. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=350 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=350&handle=fela Comment: it could be very helpful class. 1. is $this->sys private access variable? It should be $this->_sys in this case 2. Each method (like getAppData(), getDesktop(), etc.) looks similar to others. In each of these methods you have defined an array and each method contains foreach. Im sure it can be refactored and some repeated code can be moved to private methods. After that you should have shorter code :) 3. you should move array with language data to begin of file or to separate config file. It could not be mixed with php code 4. please think if it is possible to add getting php and pear directories. it can be also helpful. -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#41658) next »