Re: [PEPr] +1 for System::System_Folders

Hi Michal, Michal Felski wrote:

2. Each method (like getAppData(), getDesktop(), etc.) looks similar to others. In each of these methods you have defined an array and each method contains foreach. Im sure it can be refactored and some repeated code can be moved to private methods. After that you should have shorter code :) 3. you should move array with language data to begin of file or to separate config file. It could not be mixed with php code

That's what I asked Christian for initially. However, he doesn't see the necessity for it. He argues that the language data is "static". But I fully agree with you that the refactoring should be looked at. -- Stefano