RE: [PECL-DEV] [Proposal] id3v1

Hi Stephan, Just a quick note to say that I don't have a problem with putting this into PECL. In response to your earlier email, I think naming the extension "id3" is better than "id3v1" as it make things easier for the end user when you write support for later versions. So, go ahead and create the new package (http://pecl.php.net/package-new.php). The process should be familiar to you if you have already published PEAR packages, since we use the same infrastructure. One comment on your code: you should use the ENFORCE_SAFE_MODE|STREAM_MUST_SEEK flags in addition to REPORT_ERRORS when you open your stream. The first of these should be self-explanatory, the latter is required to make the stream seekable when opening remote files. Actually, two comments ;-) I think you can drop most of the functions and just stick with the get_tag() function. This will make things much simpler for you when you add support for newer tag versions as you won't need to maintain any state in between function calls. --Wez. > -----Original Message----- > From: Stephan Schmidt [mailto:schst@php-tools.net] > Sent: 06 June 2004 16:09 > To: pecl-dev@lists.php.net > Subject: [PECL-DEV] [Proposal] id3v1 > > Hi, > > As stated yesterday, I'm working on a extension that is able to read > ID3v1 tags. There's already some sourcecode available in CVS: > > > http://cvs.php-tools.net/horde/chora/cvs.php/pecl/id3v1?rt=schst > > Currently it's possible to extract information from ID3 v1.0 > files, I'll > add support for v1.1 shortly (allows to store information on > the track > number) and in the future I plan support for writing > information to the > files. > > Could this be somehow integrated into PECL? It's the first work I've > done for pecl, so I'm not sure how the procedures are. Would also be > great if someone could point me to problems in my code, if > there are some. > > Best regards, > > Stephan > > -- > PECL development discussion Mailing List (http://pecl.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > >