Re: Add a constant to reflect --with-curlwrappers

On Mon, Apr 1, 2013 at 7:18 AM, Hannes Magnusson <hannes.magnusson@gmail.com > wrote: > On Sun, Mar 31, 2013 at 6:25 AM, Laruence <laruence@php.net> wrote: > > Hey: > > > > there are some issues when people run some codes in a php which is > > compiled with --with-curlwrappers, like #61336, or the recently test > script > > for #64433 (failed when curl wrappers enabled). > > > > I know, that the curl wrapper should act the same as php http wrapper, > > but for now, we need to provide the ability to user, that they can warn > if > > they codes can not run with curl wrappers.. > > > > here are some really usages: > > https://github.com/UnionOfRAD/lithium/issues/59 and > > http://weizhifeng.net/wrong-with-curlwrappers.html > > > > I propose to add a constant : bool CURL_WRAPPERS_ENABLE > > The curl wrappers have always been a major pain, with plenty of bugs > and we tend to forget to add context options there to match the > standard wrapper on new feature. > > It has been marked as experimental since forever, and I think its time > to face the failed experiment and remove it. > Hey: remove is also okey for me, but, I think it probably can only happen in 5.6 before that, I think a flag to 5.4+ is a good choice :) thanks > > -Hannes > -- Laruence Xinchen Hui http://www.laruence.com/