Re: Add a constant to reflect --with-curlwrappers

On Fri, Apr 5, 2013 at 8:54 PM, Hannes Magnusson <hannes.magnusson@gmail.com > wrote: > On Fri, Apr 5, 2013 at 7:14 AM, Julien Pauli <jpauli@php.net> wrote: > > On Fri, Apr 5, 2013 at 12:51 PM, Johannes Schlüter < > johannes@schlueters.de> > > wrote: > >> > >> On Fri, 2013-04-05 at 08:01 +0200, Pierre Joye wrote: > >> > > stream_wrapper_unregister("http"); > >> > > stream_wrapper_register("http", "CurlStreamWrapper"); > >> > > and then stream_wrapper_restore("http") to go back to the core > >> > streams. > >> > > > >> > > >> > I wonder what one will do with open streams during the switches. That > >> > can't go well. > >> > >> For open streams there should be no issue - they hold the pointer to > >> their respective implementation. > >> > >> The issue I see is that libraries might change that for whatever reasons > >> and not fix it up before passing control to some other library, thus > >> creating a hardly debugable mess. > > > > > > I'm feeling like we wont be able to make it stable for 5.5 final. > > > > Right, I don't think its worth actually fixing this for 5.5, the > current experiment should be removed by 5.5 and then the possibility > to register the curl stream wrapper from userland could be introduced > in 5.5.1 for example. > > For now, simply removing the config switch would be the quickest way > to achieve progress with minimal changes back and forth if anyone > wants to make that class. > > Beta3 has been taggued with curl wrappers, and with the new CURL_WRAPPERS_ENABLED constant :-p Do we all agree to remove that feature (meaning moving it to a branch, or somewhere for the interested developers to keep on making it stable) for 5.5 stable or no ? Julien.Pauli > -Hannes >