Re: Add a constant to reflect --with-curlwrappers
| From: | Pierre Joye | Date: | Wed, 03 Apr 2013 08:41:01 +0000 |
| Subject: | Re: Add a constant to reflect --with-curlwrappers | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-66908@lists.php.net to get a copy of this message | ||
On Wed, Apr 3, 2013 at 10:22 AM, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
> Hi!
>
>> Added new constant CURL_WRAPPERS_ENABLE in (include 5.4)
>>
>> https://github.com/php/php-src/commit/d7f709a032a40cb475042b43db07a4698a2488b7
>
> I must say the process of how it was done was not very good. Not only
> there were no substantial discussion on adding this new thing in stable
> version before the commit, the time between message announcing it and
> asking if there are any objections and the commit was barely a day. It's
> not enough time at all to solicit feedback, and this change is not
> really something urgent that needs to be committed ASAP. And it turns
> out, there *are* objections. Could we be a little less quick with
> commits into a stable version and give it some time when we're talking
> about new things and not bugfixes?
I'd to agree. I was surprised to see a commit this morning.
Cheers,
--
Pierre
@pierrejoye