Re: Add a constant to reflect --with-curlwrappers

From: Date: Thu, 04 Apr 2013 19:52:08 +0000
Subject: Re: Add a constant to reflect --with-curlwrappers
References: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15  Groups: php.internals 
Request: Send a blank email to internals+get-66961@lists.php.net to get a copy of this message
On Thu, Apr 4, 2013 at 11:27 AM, Pierrick Charron <pierrick@adoy.net> wrote: > Hi > > I don't think we should remove curlwrappers from 5.5. I do agree that this > is not yet stable and ready to push as non experimental, but since we plan > to release 5.5 soon I don't think removing it right now is worth it. > > I started some time ago to maintain the curl extension. I focused mainly on > adding to ext/curl all options from the libcurl api that were not available > in PHP userspace. I also fixed some bugs on curlwrappers and will be please > to fix (or at least try to fix) all bugs that we may have with curl and curl > wrappers in the hope that it will be stable enough to be release with php > nexté > > If you have a bug with curlwrapper (or anything related to ext/curl) please > assign me the bug on the tracker and I will try to look at them ASAP. Its not only about maintaining it. This experiment failed a long time ago. Overwriting the core streams has proven itself to be the wrong way. If there was a way for userspace to say "overload with curl" then thats fine. We already have a procedure for this: stream_wrapper_unregister("http"); stream_wrapper_register("http", "CurlStreamWrapper"); and then stream_wrapper_restore("http") to go back to the core streams. I would definitely see the benefits in something like that, but as things are now are simply not working and should be removed. The "real way" can be re-implemented later. -Hannes

« previous php.internals (#66961) next »