Re: Add a constant to reflect --with-curlwrappers

发自我的 iPhone 在 2013-4-3，13:56，Hannes Magnusson <hannes.magnusson@gmail.com> 写道： > Wait wait wait. You are introducing a constant that is going to be > available as of 5.4.15 to 5.4.2x and then removed (as it looks like we > are agreeing)? how could that be? This constant will in the final release of 5.5.0. Thanks > > People have been living without this constant forever now so people > have their workarounds in place and no need to complicate their code > to for the existence of this constant which is only available for few > bugfix releases anyway? > > -Hannes > > On Tue, Apr 2, 2013 at 7:19 PM, Laruence <laruence@php.net> wrote: >> Added new constant CURL_WRAPPERS_ENABLE in (include 5.4) >> >> https://github.com/php/php-src/commit/d7f709a032a40cb475042b43db07a4698a2488b7 >> >> thanks >> >> >> On Mon, Apr 1, 2013 at 9:53 PM, Laruence <laruence@php.net> wrote: >>> >>> >>> >>> >>> On Mon, Apr 1, 2013 at 7:18 AM, Hannes Magnusson >>> <hannes.magnusson@gmail.com> wrote: >>>> >>>> On Sun, Mar 31, 2013 at 6:25 AM, Laruence <laruence@php.net> wrote: >>>>> Hey: >>>>> >>>>> there are some issues when people run some codes in a php which is >>>>> compiled with --with-curlwrappers, like #61336, or the recently test >>>>> script >>>>> for #64433 (failed when curl wrappers enabled). >>>>> >>>>> I know, that the curl wrapper should act the same as php http >>>>> wrapper, >>>>> but for now, we need to provide the ability to user, that they can warn >>>>> if >>>>> they codes can not run with curl wrappers.. >>>>> >>>>> here are some really usages: >>>>> https://github.com/UnionOfRAD/lithium/issues/59 >>>>> and >>>>> >>>>> http://weizhifeng.net/wrong-with-curlwrappers.html >>>>> >>>>> I propose to add a constant : bool CURL_WRAPPERS_ENABLE >>>> >>>> The curl wrappers have always been a major pain, with plenty of bugs >>>> and we tend to forget to add context options there to match the >>>> standard wrapper on new feature. >>>> >>>> It has been marked as experimental since forever, and I think its time >>>> to face the failed experiment and remove it. >>> >>> >>> Hey: >>> >>> remove is also okey for me, but, I think it probably can only happen in >>> 5.6 >>> >>> before that, I think a flag to 5.4+ is a good choice :) >>> >>> thanks >>>> >>>> >>>> -Hannes >>> >>> >>> >>> >>> -- >>> Laruence Xinchen Hui >>> http://www.laruence.com/ >> >> >> >> >> -- >> Laruence Xinchen Hui >> http://www.laruence.com/