RE: ip-to-country - summary

On Fri, 2 May 2003, Divyank Turakhia wrote: > Original: > > function i2c_ip2num($dotted) > { > $dotted = preg_split("/[.]+/", $dotted); > return (float) ($dotted[0] * 16777216) + > ($dotted[1] * 65536) + > ($dotted[2] * 256) + > ($dotted[3]); > } > > Suggested Change: > > function i2c_ip2num($dotted) > { > $dotted = preg_split("/[.]+/", $dotted); > return ($dotted[0] << 24) | ($dotted[1] << 16) | ($dotted[2] << 8) | > $dotted[3]; > } > > > Since a multiplication takes 8 cpu cycles while a shift operator takes > 2, this would give a slight boost. That might be so in assembly, but definitely not in PHP :) The difference would be too small to measure, so I opt for the better readable (Goba's) version. Derick -- ------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ JDI Media Solutions http://www.jdimedia.nl/ PHP Magazine - PHP Magazine for Professionals http://php-mag.net/ -------------------------------------------------------------------------